voonhous commented on code in PR #19809:
URL: https://github.com/apache/hudi/pull/19809#discussion_r3916141747
##########
hudi-common/src/test/java/org/apache/hudi/common/avro/TestHoodieAvroUtils.java:
##########
@@ -955,6 +1079,21 @@ void
testGetSortColumnValuesWithPartitionPathAndRecordKey(boolean suffixRecordKe
}
}
+ @Test
+ void testGetRecordColumnValues() {
Review Comment:
Done in 2abcfe1e3a9c. Rather than a shared helper, the test now uses
`SCHEMA_WITH_NESTED_FIELD_STR`, so nothing is duplicated and it pins a nested
`student.firstnameNested`, a nested null and a missing column (null).
##########
hudi-common/src/main/java/org/apache/hudi/common/schema/LocalHoodieSchemaCache.java:
##########
@@ -46,7 +46,10 @@ private LocalHoodieSchemaCache() {
this.schemaToVersionId = new HashMap<>();
}
- public static LocalHoodieSchemaCache getInstance() {
+ /**
+ * Returns a new, empty cache. Each caller owns its own version-id space.
+ */
+ public static LocalHoodieSchemaCache create() {
Review Comment:
Done in 2abcfe1e3a9c: `TestLocalHoodieSchemaCache` restores the two tests
from `TestLocalAvroSchemaCache` (four distinct schemas get four ids; two parses
of the same schema share one id).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
