voonhous commented on code in PR #19809:
URL: https://github.com/apache/hudi/pull/19809#discussion_r3916149704
##########
hudi-common/src/test/java/org/apache/hudi/common/table/read/lsm/TestLsmFileGroupRecordIterator.java:
##########
@@ -166,7 +166,7 @@ void testUpdateProcessorOnlyRunsForRecordsFromLogs() throws
Exception {
@Test
void testDeleteLogSchemaUsesRecordKeyAndOrderingFields() {
- HoodieSchema deleteLogSchema =
HoodieSchemas.createDeleteLogSchema(tableSchema(), Arrays.asList("ts"));
+ HoodieSchema deleteLogSchema =
HoodieSchemaUtils.createDeleteLogSchema(tableSchema(), Arrays.asList("ts"));
Review Comment:
Done in 2abcfe1e3a9c.
##########
hudi-common/src/main/java/org/apache/hudi/common/avro/HoodieAvroUtils.java:
##########
@@ -221,7 +259,7 @@ public static byte[] avroToFileBytes(IndexedRecord record) {
* @param record The GenericRecord to convert
* @param pretty Whether to pretty-print the json output
*/
- public static String avroToJsonString(GenericRecord record, boolean pretty)
throws IOException {
+ private static String avroToJsonString(GenericRecord record, boolean pretty)
throws IOException {
Review Comment:
Done in d74b3cd4f3b6: now links `avroToJson(GenericRecord, boolean)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
