voonhous commented on code in PR #19869:
URL: https://github.com/apache/hudi/pull/19869#discussion_r3966517996
##########
hudi-common/src/test/java/org/apache/hudi/common/util/TestExternalFilePathUtil.java:
##########
@@ -230,4 +230,19 @@ public void testRoundTrip_WithPrefix() {
assertEquals(prefix + "/" + originalFile, parsed[0]);
assertEquals(COMMIT_TIME, parsed[1]);
}
+
+ @Test
+ public void testGetFilePathInPartition() {
Review Comment:
One small regression in b10d8167: both marker-form assertions were dropped
when the nested case was added, the plain
`file1.parquet_20240101000000_hudiext` yielding `file1.parquet` and the
single-level `fg%3Dbucket-0` yielding `bucket-0/file1.parquet`. The plain shape
is the one `BaseFileRecordParsingUtils:240` hits for prefix-less files, and the
single-level prefix is what the functional test's `bucket-0/` parameterization
exercises end to end. Could the two one-liners come back alongside the nested
case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
