voonhous commented on code in PR #19869:
URL: https://github.com/apache/hudi/pull/19869#discussion_r3966512901
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/index/record/BaseRecordIndexer.java:
##########
@@ -478,11 +478,48 @@ private HoodieData<HoodieRecord>
getRecordIndexAdditionalUpserts(
} else if (operationType == WriteOperationType.DELETE_PARTITION) {
// all records from the target partition(s) to be deleted from RLI
return getRecordIndexReplacedRecords((HoodieReplaceCommitMetadata)
commitMetadata, fsView);
Review Comment:
One more data point for the follow-up's scope: the repo's own external-file
registration test, `TestExternalPathHandling:115`, commits with
`INSERT_OVERWRITE`, so the canonical in-repo flow takes the branch this PR does
not gate. That branch also has the file-name twin of the bug fixed at
`SecondaryIndexRecordGenerationUtils:322`: `HoodieTableMetadataUtil:2021` and
`:2079` build the path from `baseFile.getFileName()`, dropping a `bucket-0/`
prefix. DELETE_PARTITION shares the path. Worth listing all three in the
follow-up so it is complete?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
