hudi-agent commented on code in PR #19811:
URL: https://github.com/apache/hudi/pull/19811#discussion_r3977457895
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/HoodieMultiTableStreamer.java:
##########
@@ -389,6 +406,16 @@ public static class Config implements Serializable {
+ " source-fetch -> Transform -> Hudi Write in loop")
public Boolean continuousMode = false;
+ @Parameter(names = {"--fail-fast-on-continuous"},
+ description = "Only applies in continuous mode. When enabled, the
first table failure immediately tears "
+ + "down the remaining table syncs; they are interrupted mid-round
rather than allowed to finish it, so a "
+ + "table can be left with an inflight instant that is rolled back
on the next run. When disabled "
+ + "(default), each table is synced independently and a single
failure does not stop the others. Either "
+ + "way, if the run ends at all with a failed table the job exits
with a non-zero status, since continuous "
+ + "mode is not meant to end. A table failing while the others keep
running does not end the run, so it "
+ + "surfaces through that table's error log and metrics rather than
the exit code.")
+ public Boolean failFastOnContinuousMode = false;
Review Comment:
🤖 nit: this `--help` description is quite a wall of text; could you trim it
to the essentials (fail-fast tears down siblings on first failure; default lets
others continue) and keep the inflight-instant / exit-code nuances in the
`syncContinuously()` javadoc, which already covers them?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
