hudi-agent commented on code in PR #19811:
URL: https://github.com/apache/hudi/pull/19811#discussion_r3974547136
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/HoodieMultiTableStreamer.java:
##########
@@ -389,6 +406,16 @@ public static class Config implements Serializable {
+ " source-fetch -> Transform -> Hudi Write in loop")
public Boolean continuousMode = false;
+ @Parameter(names = {"--fail-fast-on-continuous"},
+ description = "Only applies in continuous mode. When enabled, the
first table failure immediately tears "
Review Comment:
🤖 nit: this `--help` description is eight lines of caveats; could you trim
it to the one-line behavior ("In continuous mode, stop all table syncs on the
first table failure. Default: false") and move the inflight-instant / exit-code
details into the Javadoc on `syncContinuously()`, which already covers most of
it?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/HoodieStreamer.java:
##########
@@ -220,6 +220,20 @@ public void shutdownGracefully() {
});
}
+ /**
+ * Interrupts an in-progress ingestion. Unlike {@link #shutdownGracefully()}
this neither closes nor waits: the sync
+ * is still running, and the thread owning it releases the resources once it
returns. The interrupt lands mid-round,
+ * so the table can be left with an inflight instant that is rolled back on
the next run.
+ */
+ public void interruptIngestion() {
+ ingestionService.ifPresent(ds -> {
+ if (!ds.isShutdown()) {
+ log.info("Forcefully shutting down DeltaStreamer");
Review Comment:
🤖 nit: the log line says "Forcefully shutting down" but the method is
`interruptIngestion()` and the Javadoc stresses it neither closes nor waits —
could you align the message (e.g. "Interrupting ingestion for table {}" with
the target table name) so a reader of the driver log doesn't assume the
streamer was fully shut down?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
