hudi-agent commented on code in PR #19882:
URL: https://github.com/apache/hudi/pull/19882#discussion_r3996750449
##########
hudi-trino/src/main/java/io/trino/plugin/hudi/storage/HudiTrinoStorage.java:
##########
@@ -54,6 +54,25 @@ public HudiTrinoStorage(TrinoFileSystem fileSystem,
TrinoStorageConfiguration st
this.fileSystem = fileSystem;
}
+ public HudiTrinoStorage(StoragePath path, StorageConfiguration<?>
storageConf)
+ {
+ this(requireTrinoStorageConfiguration(storageConf, path), path);
+ }
+
+ private HudiTrinoStorage(TrinoStorageConfiguration storageConf,
StoragePath path)
+ {
Review Comment:
🤖 nit: this ends up with two overloaded 3-arg-vs-2-arg private constructors
chained through a static helper just to validate/unwrap the config — might be
simpler as a single constructor body with two sequential checks (instanceof,
then orElseThrow) rather than delegating through
`requireTrinoStorageConfiguration`.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
