OjashKush commented on code in PR #19882:
URL: https://github.com/apache/hudi/pull/19882#discussion_r3996132623
##########
hudi-trino/src/main/java/io/trino/plugin/hudi/storage/TrinoStorageConfiguration.java:
##########
@@ -28,14 +30,32 @@ public class TrinoStorageConfiguration
{
private final Map<String, String> configMap;
+ private final transient TrinoFileSystem fileSystem;
+
public TrinoStorageConfiguration()
{
- this(getDefaultConfigs());
+ this(getDefaultConfigs(), null);
+ }
+
+ public TrinoStorageConfiguration(TrinoFileSystem fileSystem)
Review Comment:
Your caller enumeration is the better argument, since it doesn't depend on
the connector's own call graph. I've added it to the description: the only
production callers are ActiveTimelineV1/V2.createFileInPath and
createImmutableFileInPath, both instant-file writes, so a read-only connector
can't reach them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
