nanjeshramesh opened a new pull request, #19944:
URL: https://github.com/apache/hudi/pull/19944
### Describe the issue this Pull Request addresses
Closes #14528.
HoodieBaseFile was previously named HoodieDataFile. Per the cWiki design and
arch page, we should converge on one name, and many call sites across the
codebase still name variables of this type dataFile or df rather than baseFile
or bf.
### Summary and Changelog
Renames every local variable, field, method parameter, and lambda argument
whose declared or inferred type is HoodieBaseFile (or a direct
List/Stream/Option/Collection of it) from dataFile/df to baseFile/bf, across 35
files in hudi-common, hudi-hadoop-common, hudi-hadoop-mr,
hudi-sync/hudi-hive-sync, hudi-client-common, hudi-spark-client,
hudi-java-client, hudi-flink-client, and hudi-spark-datasource.
Deliberately out of scope:
- Method names such as `HoodieFileGroup#getLatestDataFile` and
`TestHoodieBaseFile#newDataFile` are unchanged. Renaming a method, especially a
public one, is a materially different, higher risk change than renaming a local
variable or parameter, and the issue's own wording ("all variables of this
type") does not ask for it.
- Identifiers that are not of type HoodieBaseFile even though they contain
"dataFile" in the name, for example `dataFileName` (String),
`skipCreatingDataFile` (boolean), and the several FileSlice-typed
`orphan/inflightFileSliceWithDataFile` locals in
`TestHoodieTableFileSystemView`. Each was checked individually against its
actual declared or inferred type before being included or excluded.
- `df`/`dataFile` identifiers that are unrelated Spark DataFrames or other
types entirely, such as `StreamSync`'s `transformed.map(df -> ...)` and
`IncrementalTimelineSyncFileSystemView`'s `deltaFileGroups.stream().map(df ->
df.getTimeline())`, the latter being a HoodieFileGroup, not a HoodieBaseFile,
despite sitting one line away from two genuine HoodieBaseFile `df` usages that
were renamed.
An earlier attempt at this same issue (#1650) was opened in 2022 and closed
unmerged after review stalled. A good number of the dataFile/df sites it
touched have since been renamed independently in other changes, which is why
this diff is smaller in file count than that one.
Pure rename, no behavior change: 281 insertions, 281 deletions.
### Impact
None. Internal identifier renaming only, no public API, storage format, or
behavior change.
### Risk Level
low
Verified by test-compiling every touched module (hudi-common,
hudi-hadoop-common, hudi-hadoop-mr, hudi-hive-sync, hudi-client-common,
hudi-spark-client, hudi-java-client, hudi-flink-client,
hudi-spark-datasource/hudi-spark and its spark3.5 dependency chain) against JDK
11 with zero compile errors.
### Documentation Update
none
### Contributor's checklist
- [x] Read through [contributor's
guide](https://hudi.apache.org/contribute/how-to-contribute)
- [x] Enough context is provided in the sections above
- [x] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
