hudi-agent commented on code in PR #19944:
URL: https://github.com/apache/hudi/pull/19944#discussion_r4007074511
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/CompactionAdminClient.java:
##########
@@ -232,17 +232,17 @@ private ValidationOpResult
validateCompactionOperation(HoodieTableMetaClient met
.filter(fs ->
fs.getFileId().equals(operation.getFileId())).findFirst());
if (fileSliceOptional.isPresent()) {
FileSlice fs = fileSliceOptional.get();
- Option<HoodieBaseFile> df = fs.getBaseFile();
+ Option<HoodieBaseFile> bf = fs.getBaseFile();
Review Comment:
🤖 nit: everywhere else in this PR `dataFile`/`df` is renamed to the full
`baseFile`, but here it becomes the terse `bf`. Could you use `baseFile` for
consistency with the rest of the rename?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/compact/strategy/TestHoodieCompactionStrategy.java:
##########
@@ -517,17 +517,17 @@ private List<HoodieCompactionOperation>
createCompactionOperations(HoodieWriteCo
List<HoodieCompactionOperation> operations = new
ArrayList<>(sizesMap.size());
sizesMap.forEach((k, v) -> {
- HoodieBaseFile df = TestHoodieBaseFile.newDataFile(k);
+ HoodieBaseFile bf = TestHoodieBaseFile.newDataFile(k);
Review Comment:
🤖 nit: this uses `bf` while sibling test/util classes in the same PR (e.g.
TestCleanerInsertAndCleanByVersions) use the full `baseFile` — worth aligning
on one convention across the PR.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
