voonhous commented on code in PR #19985:
URL: https://github.com/apache/hudi/pull/19985#discussion_r4036501420
##########
hudi-trino/src/test/java/io/trino/plugin/hudi/TestHudiMemoryCacheFileOperations.java:
##########
@@ -70,6 +71,7 @@ protected DistributedQueryRunner createQueryRunner()
}
@Test
+ @Disabled("Asserts the exclusions of HudiCacheKeyProvider in the metadata
memory cache (table properties and index definitions are re-read from storage
on every query). release-1.2.1 does not bind that provider, so Trino's default
provider caches those files and the counts no longer hold. Re-enable together
with the binding in HudiModule.")
Review Comment:
Added testReadsServedFromMemoryCache in 1582b741b04e:
fs.cache.enabled=false, metadata cache on, warms it and asserts a repeat query
reads data files through the memory cache without opening any from storage. The
two count assertions stay disabled since they encode HudiCacheKeyProvider's
exclusions; they come back with the binding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
