voonhous commented on code in PR #19985:
URL: https://github.com/apache/hudi/pull/19985#discussion_r4036426517
##########
hudi-trino/src/main/java/io/trino/plugin/hudi/HudiModule.java:
##########
@@ -75,7 +72,10 @@ public void configure(Binder binder)
binder.bind(FileFormatDataSourceStats.class).in(Scopes.SINGLETON);
newExporter(binder).export(FileFormatDataSourceStats.class).withGeneratedName();
- newOptionalBinder(binder,
CacheKeyProvider.class).setBinding().to(HudiCacheKeyProvider.class).in(Scopes.SINGLETON);
+ // HudiCacheKeyProvider is deliberately not bound on release-1.2.1, so
Trino's default
+ // provider is used. It implements the Trino 483 CacheKeyProvider
contract, which changed
Review Comment:
The unbound path falls back to Trino's own DefaultCacheKeyProvider
(FileSystemModule binds it as the default), the same provider the Hive
connector runs with for files that can be rewritten in place, and Trino covers
its invalidation in
TestAlluxioCacheFileSystemAccessOperations.testCacheInvalidation. This change
is release-only so the 1.2.1 connector stays loadable on Trino after 483;
master keeps HudiCacheKeyProvider and its exclusions, and the binding returns
here once the connector targets the newer contract. So I'd rather not add a
Hudi-side freshness test for Trino's provider in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
