wombatu-kun commented on code in PR #19987:
URL: https://github.com/apache/hudi/pull/19987#discussion_r4043353092
##########
pom.xml:
##########
@@ -104,7 +104,9 @@
<fasterxml.jackson.databind.version>${fasterxml.spark3.version}</fasterxml.jackson.databind.version>
<fasterxml.jackson.module.scala.version>${fasterxml.spark3.version}</fasterxml.jackson.module.scala.version>
<fasterxml.jackson.dataformat.yaml.version>${fasterxml.spark3.version}</fasterxml.jackson.dataformat.yaml.version>
- <kafka.version>2.0.0</kafka.version>
+ <!-- Used by every build that selects no Spark profile: the JDK-activated
java11/java17 profiles always
+ turn off the activeByDefault spark3.5 profile. Keep in sync with
spark3.5. -->
Review Comment:
The same mechanism also leaves `hudi-spark3.5.x`, `hudi-spark3-common` and
`hudi-flink2.2.x` out of the reactor, so the release guide's `mvn -Prelease
clean install` resolves them from the local repository instead of building
them. Should `release/release_guide.md` name a Spark and a Flink profile, like
the all-modules line in `deploy_staging_jars.sh` (follow-up, not a blocker)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
