hudi-agent commented on code in PR #19987:
URL: https://github.com/apache/hudi/pull/19987#discussion_r4043854928
##########
pom.xml:
##########
@@ -104,7 +104,9 @@
<fasterxml.jackson.databind.version>${fasterxml.spark3.version}</fasterxml.jackson.databind.version>
<fasterxml.jackson.module.scala.version>${fasterxml.spark3.version}</fasterxml.jackson.module.scala.version>
<fasterxml.jackson.dataformat.yaml.version>${fasterxml.spark3.version}</fasterxml.jackson.dataformat.yaml.version>
- <kafka.version>2.0.0</kafka.version>
+ <!-- Used by every build that selects no Spark profile: the JDK-activated
java11/java17 profiles always
+ turn off the activeByDefault spark3.5 profile. Keep in sync with
spark3.5. -->
Review Comment:
🤖 Confirmed from the pom: `hudi-spark3.5.x`, `hudi-spark3-common` and
`hudi-flink2.2.x` only appear inside profile `<modules>` blocks (lines
2853-2854 and 3103), never in the root module list. Worth noting that
`-Prelease` itself is "another profile in the same POM", so the activeByDefault
`spark3.5`/`flink2.2` profiles are dropped by that flag alone, independent of
the JDK-triggered `java11`/`java17` profiles — so naming a Spark and Flink
profile in the release guide seems needed regardless of which JDK the release
manager runs on. Agree that's a follow-up rather than something for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
