danny0405 commented on code in PR #20009:
URL: https://github.com/apache/hudi/pull/20009#discussion_r4055821383
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -180,6 +183,16 @@ public class HoodieTableConfig extends HoodieConfig {
+ " to identify what upgrade/downgrade paths happened on the table.
This is only configured "
+ "when the table is initially setup.");
+ public static final ConfigProperty<String> MAX_ALLOWED_TABLE_VERSION =
ConfigProperty
+ .key("hoodie.table.version.pinned")
+ .defaultValue("UN_PINNED")
+ .withDocumentation("Ceiling on hoodie.table.version: loading or writing
a table whose version exceeds "
Review Comment:
> loading or writing a table whose version exceeds this value throws
immediately
Instead of upgrade first then validate and throw, I would suggest we disable
the upgrade in the very first place which is more clear and also user-friendly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
