danny0405 commented on code in PR #20009:
URL: https://github.com/apache/hudi/pull/20009#discussion_r4055830718
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -180,6 +183,16 @@ public class HoodieTableConfig extends HoodieConfig {
+ " to identify what upgrade/downgrade paths happened on the table.
This is only configured "
+ "when the table is initially setup.");
+ public static final ConfigProperty<String> MAX_ALLOWED_TABLE_VERSION =
ConfigProperty
+ .key("hoodie.table.version.pinned")
+ .defaultValue("UN_PINNED")
+ .withDocumentation("Ceiling on hoodie.table.version: loading or writing
a table whose version exceeds "
+ + "this value throws immediately, so an accidental upgrade is caught
before it silently makes the "
+ + "table unreadable by older readers. A version at or below the pin
is unaffected. Also honored as "
+ + "a JVM system property of the same key (this config value takes
precedence over the system "
Review Comment:
> a JVM system property of the same key (this config value takes precedence
over the system
looks risky and might cause config leaks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
