hudi-agent commented on code in PR #19944:
URL: https://github.com/apache/hudi/pull/19944#discussion_r4075953889
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieCompactionHandler.java:
##########
@@ -37,7 +37,7 @@
*/
public interface HoodieCompactionHandler<T> {
Iterator<List<WriteStatus>> handleUpdate(String instantTime, String
partitionPath, String fileId,
- Map<String, HoodieRecord<T>>
keyToNewRecords, HoodieBaseFile oldDataFile) throws IOException;
+ Map<String, HoodieRecord<T>>
keyToNewRecords, HoodieBaseFile baseFile) throws IOException;
Review Comment:
🤖 nit: `oldDataFile` / `dataFileToBeMerged` said *which* base file this is
(the one being merged into and superseded); plain `baseFile` drops that. Could
you use `baseFileToMerge` here and in the merge-handle constructors, matching
the existing `baseFileForMerge()` accessor on `HoodieMergeHandle`?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
