hudi-agent commented on code in PR #20020:
URL: https://github.com/apache/hudi/pull/20020#discussion_r4078932100
##########
packaging/hudi-gcp-bundle/pom.xml:
##########
@@ -99,7 +99,24 @@
<include>org.apache.hudi:hudi-hive-sync</include>
<include>org.apache.hudi:hudi-gcp</include>
<include>org.apache.parquet:parquet-avro</include>
- <include>com.google.cloud:google-cloud-bigquery</include>
+ <!-- Google Cloud SDK -->
+ <include>com.google.cloud:*</include>
+ <include>com.google.api:*</include>
+
<include>com.google.apis:google-api-services-storage</include>
Review Comment:
🤖 Narrowing `com.google.apis:*` to just `google-api-services-storage` also
drops `com.google.apis:google-api-services-bigquery` (a direct compile dep of
`google-cloud-bigquery:2.26.0`), which `BigQueryOptions`' default RPC
(`HttpBigQueryRpc`) needs — that would break `BigQuerySyncTool` from this
bundle. Could you keep it included as well?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
##########
packaging/hudi-gcp-bundle/pom.xml:
##########
@@ -99,7 +99,24 @@
<include>org.apache.hudi:hudi-hive-sync</include>
<include>org.apache.hudi:hudi-gcp</include>
<include>org.apache.parquet:parquet-avro</include>
- <include>com.google.cloud:google-cloud-bigquery</include>
+ <!-- Google Cloud SDK -->
+ <include>com.google.cloud:*</include>
+ <include>com.google.api:*</include>
+
<include>com.google.apis:google-api-services-storage</include>
+ <include>com.google.api-client:*</include>
+ <include>com.google.api.grpc:*</include>
+ <include>com.google.auth:*</include>
+ <include>com.google.code.gson:gson</include>
+ <include>com.google.http-client:*</include>
+ <include>com.google.oauth-client:*</include>
+ <include>com.google.protobuf:*</include>
+ <include>io.grpc:*</include>
+ <include>io.opencensus:*</include>
+ <include>io.perfmark:*</include>
+ <include>org.threeten:threetenbp</include>
Review Comment:
🤖 Same concern for `org.threeten:*` → `threetenbp`: the tree also has
`org.threeten:threeten-extra:1.7.2` as a direct dep of `google-cloud-bigquery`
(used for `PeriodDuration` in `FieldValue`/INTERVAL handling), and it's no
longer matched. Worth including it too?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
