hudi-agent commented on code in PR #20020:
URL: https://github.com/apache/hudi/pull/20020#discussion_r4088917649
##########
packaging/hudi-gcp-bundle/pom.xml:
##########
@@ -114,6 +133,10 @@
<pattern>org.openjdk.jol.</pattern>
<shadedPattern>org.apache.hudi.org.openjdk.jol.</shadedPattern>
</relocation>
+ <relocation>
+ <pattern>com.google.common.</pattern>
Review Comment:
🤖 The guava jar also ships `com.google.thirdparty.publicsuffix.*`, which
this pattern doesn't cover, so the bundle ends up with a relocated
`com.google.common` half and an un-relocated `com.google.thirdparty` half.
Would it be worth adding a `com.google.thirdparty.` relocation too, so
`InternetDomainName` can't bind to an older guava's publicsuffix tables (or
shadow the cluster's) at runtime?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
