danny0405 commented on code in PR #20138:
URL: https://github.com/apache/hudi/pull/20138#discussion_r4139875047
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteFunction.java:
##########
@@ -589,7 +590,7 @@ private void sortBucketIfNeeded(RowDataBucket
rowDataBucket) {
return;
}
try {
- rowDataBucket.sort();
+ rowDataBucket.sort(readerContext.getMergeMode() ==
RecordMergeMode.COMMIT_TIME_ORDERING);
Review Comment:
even for event time merging, we want the commit time sequence fallback when
ordring value equals
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
