danny0405 commented on code in PR #20138:
URL: https://github.com/apache/hudi/pull/20138#discussion_r4143736545
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/append/AppendWriteFunctionWithBIMBufferSort.java:
##########
@@ -207,7 +207,7 @@ private void waitForAsyncWriteCompletion() {
* 2. Binary buffer is full.
* 3. `endInput` is called for pipelines with a bounded source.
*/
- private void sortAndSend(BinaryInMemorySortBuffer buffer) throws IOException
{
+ private void sortAndSend(RowDataSortBuffer buffer) throws IOException {
Review Comment:
do we need to the sort to be stable for append mode?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
