pengzhiwei2018 commented on pull request #2645:
URL: https://github.com/apache/hudi/pull/2645#issuecomment-815583131


   Hi @vinothchandar @kwondw , Thanks for the review on this feature. The code 
has updated.
   Main changes:
   - Sql support spark3 based on the same `HoodieAnalysis` and `Commands` with 
spark2. We can pass the test case for spark3 by the following command:  
       `mvn clean install -DskipTests -Pspark3` 
       `mvn test -Punit-tests -Pspark3 -pl hudi-spark-datasource/hudi-spark`
   -  Fix the bug when the source column name is not same with the target table 
column name, MergeInto not work. e.g. `mere into ... on t0.id = s0.s_id`
   -  Support expression on source columns for the merge-on condition. e.g.  
`merge into .... on t0.id = s0.id + 1 ...`
   -  Add more test case for `TestMergeInto` & `TestUpdate`.
   -  Remove the `tableSchema`, use `writeSchema` instead.
   
   Please take a review again when you have time, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to