danny0405 commented on code in PR #20165:
URL: https://github.com/apache/hudi/pull/20165#discussion_r4300900509
##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/ddl/HiveQueryDDLExecutor.java:
##########
@@ -126,12 +127,12 @@ public void runSQL(String sql) {
* session Driver when no pool is configured.
*/
@Override
- protected void runSQLs(List<String> sqls) {
+ protected void runSQLs(List<String> sqls, IntConsumer onStatementSucceeded) {
Review Comment:
instead of modifying these APIs, can we add a `HoodieHiveSyncMetrics` that
serves for collecting the instrested metrics, it can be then transformed into
Flink related metrics, and `HoodieHiveSyncMetrics` holds the flag for detailed
metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
