wombatu-kun commented on code in PR #20396:
URL: https://github.com/apache/hudi/pull/20396#discussion_r4325399721
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/FileGroupReaderBasedNativeLogAppendHandle.java:
##########
@@ -71,6 +72,11 @@ public
FileGroupReaderBasedNativeLogAppendHandle(HoodieWriteConfig config, Strin
this.useWriterSchema = true;
}
+ @Override
+ protected RecordContext<?> getRecordContextForWrite() {
+ return readerContext.getRecordContext();
Review Comment:
With ORC base files and the default Avro merger on table version 10, this
sends log-compaction deletes to `HoodieSparkFileWriterFactory`, whose
`newOrcFileWriter` throws `Not support write to Orc file`:
`testLogCompactionRewritesDeletesWithEngineOrdering` on ORC base files with a
`long` ordering field passes on master and aborts in log compaction with this
override. Is ORC meant to keep working on this path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
