danny0405 commented on code in PR #20413:
URL: https://github.com/apache/hudi/pull/20413#discussion_r4356019021
##########
hudi-common/src/main/java/org/apache/hudi/common/table/marker/MarkerType.java:
##########
@@ -34,7 +34,6 @@ public enum MarkerType {
@EnumFieldDescription("Marker operations are all handled at the timeline
service which serves as a proxy. "
+ "New marker entries are batch processed and stored in a limited number
of underlying files for efficiency. "
- + "If HDFS is used or timeline server is disabled, DIRECT markers are used
as fallback even if this is configured. "
- + "This configuration does not take effect for Spark structured streaming;
DIRECT markers are always used.")
+ + "If HDFS is used or timeline server is disabled, DIRECT markers are used
as fallback even if this is configured.")
Review Comment:
Non-blocking documentation suggestion: while updating this generated config
description, could we spell out the remote-view exception noted in the PR's
Impact section? WriteMarkersFactory only falls back when both the embedded
server is disabled and the view is not remote (apart from HDFS). With
REMOTE_FIRST/REMOTE_ONLY, disabling the embedded server still requires a
reachable external marker service or an explicit DIRECT setting. That
distinction is useful migration guidance now that streaming honors this option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
