nsivabalan commented on code in PR #20413:
URL: https://github.com/apache/hudi/pull/20413#discussion_r4363026953
##########
hudi-common/src/main/java/org/apache/hudi/common/table/marker/MarkerType.java:
##########
@@ -34,7 +34,6 @@ public enum MarkerType {
@EnumFieldDescription("Marker operations are all handled at the timeline
service which serves as a proxy. "
+ "New marker entries are batch processed and stored in a limited number
of underlying files for efficiency. "
- + "If HDFS is used or timeline server is disabled, DIRECT markers are used
as fallback even if this is configured. "
- + "This configuration does not take effect for Spark structured streaming;
DIRECT markers are always used.")
+ + "If HDFS is used or timeline server is disabled, DIRECT markers are used
as fallback even if this is configured.")
Review Comment:
Done — the `TIMELINE_SERVER_BASED` description now spells it out: markers
fall back to DIRECT on HDFS, or when the embedded timeline server is disabled
and the file system view is not remote; with `REMOTE_FIRST`/`REMOTE_ONLY` and
the embedded server disabled, markers go through the configured remote timeline
server, which must be reachable, otherwise DIRECT markers should be configured.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
