[GitHub] [hudi] garyli1019 commented on a change in pull request #2716: [HUDI-1718] when query incr view of mor table which has Multi level partitions, the query failed

[GitBox]

garyli1019 commented on a change in pull request #2716:
URL: https://github.com/apache/hudi/pull/2716#discussion_r611120591



##########
File path: 
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/hive/HoodieCombineHiveInputFormat.java
##########
@@ -170,7 +170,7 @@ protected HoodieCombineFileInputFormatShim 
createInputFormatShim() {
         if (job.get(hive_metastoreConstants.META_TABLE_PARTITION_COLUMNS, 
"").isEmpty()) {
           List<String> partitions = new 
ArrayList<>(part.getPartSpec().keySet());
           if (!partitions.isEmpty()) {
-            String partitionStr = String.join(",", partitions);

Review comment:
       hmm..very strange. How does this work in the first place? Was this 
separator changed between Hive2 and Hive3?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org