garyli1019 commented on a change in pull request #2716:
URL: https://github.com/apache/hudi/pull/2716#discussion_r611126464
##########
File path:
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/hive/HoodieCombineHiveInputFormat.java
##########
@@ -170,7 +170,7 @@ protected HoodieCombineFileInputFormatShim
createInputFormatShim() {
if (job.get(hive_metastoreConstants.META_TABLE_PARTITION_COLUMNS,
"").isEmpty()) {
List<String> partitions = new
ArrayList<>(part.getPartSpec().keySet());
if (!partitions.isEmpty()) {
- String partitionStr = String.join(",", partitions);
Review comment:
I see. Thanks for the explanation. Would that be possible to cover this
case in the UT? Probably we could cover this case in your other PRs cause you
already added a test case for this `HoodieCombineHiveInputFormat`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
