danny0405 commented on PR #20515:
URL: https://github.com/apache/hudi/pull/20515#issuecomment-6649326131

   Addressed in 91b39989d83.
   
   - `--metadata` now defaults to `enabled`. Fresh Spark 4.1 bundle build 
passed; both real Spark 4.1.1 CLI/Connect COW and MOR runs passed with **no 
metadata override** and **`PYTHONOPTIMIZE=1`**. The scenario additionally 
checks that both metadata tables initialize and contain completed writes.
   - Removed the #20491 / metadata-writer lifetime carve-out from 
`ACCEPTANCE.md`; recorded the enabled-run results there and in the PR 
description.
   - Strengthened replay coverage to four keys across two partitions. The 
second batch updates key 1 and adds key 4, leaving keys 2 and 3 untouched. 
Exact downstream rows ordered by `id, ts` now expose a re-read even when the 
updated key collapses to its latest state. Both tables must expose exactly 
`part=a` and `part=b`.
   - Replaced every bare `assert` in the chaining script with `require()`. Both 
the scenario and verification subprocesses ran with optimization enabled.
   - Corrected the description to “leaves #20407 open” to avoid an accidental 
closing reference.
   
   For the two non-blocking follow-ups:
   
   1. **`SELECT *`:** this PR still uses explicit business-column projection 
and does not establish wildcard support. The docs now explicitly tie wildcard 
validation to the reserved-system-field acceptance item in #20407: exercise the 
real CLI path, then establish safe stripping or a clear rejection while 
preserving the supported `_hoodie_is_deleted` input marker.
   2. **Empty downstream commits:** skipping empty sink batches is proposed 
follow-up work for #20406, with no sink behavior change in this PR. The test 
still checks compaction catch-up for business-record replay and requires the 
following quiescent restart to leave both timelines unchanged. MOR completed 
upstream compaction in the enabled run; this particular run needed no 
additional downstream catch-up commit.
   
   Python syntax compilation, `git diff --check`, and PR-body compliance 
validation also passed. The bundle build skipped unit-test execution; remote CI 
for this revision is pending.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to