wombatu-kun commented on code in PR #20526:
URL: https://github.com/apache/hudi/pull/20526#discussion_r4490648664


##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/TestHoodieCatalystExpressionUtils.scala:
##########
@@ -269,9 +272,13 @@ class TestHoodieCatalystExpressionUtils extends 
SparkAdapterSupport {
     assertEquals(None, matched(Cast(dateAttr, StringType)))
     assertEquals(None, matched(Cast(dateAttr, IntegerType)))
     assertEquals(None, matched(Cast(boolAttr, DecimalType(1, 1))))
-    // A date maps to the start of its day, and truncating a timestamp to its 
date is non-decreasing.
+    // A date maps to the start of its day.
     assertEquals(Some(dateAttr), matched(Cast(dateAttr, TimestampType)))
-    assertEquals(Some(tsAttr), matched(Cast(tsAttr, DateType)))
+    // A timestamp's local date runs backwards where the clocks fell back 
across midnight, so it is
+    // ranged with a per-file guard there (America/St_Johns), and not at all 
without a time zone.
+    assertEquals(Some(tsAttr), matched(Cast(tsAttr, DateType, Some("UTC"))))
+    assertEquals(Some(tsAttr), matched(Cast(tsAttr, DateType, 
Some("America/St_Johns"))))

Review Comment:
   Done aa2717f56832.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to