ssdong commented on a change in pull request #2784:
URL: https://github.com/apache/hudi/pull/2784#discussion_r615510834
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/ReplaceArchivalHelper.java
##########
@@ -68,6 +68,11 @@
public static boolean deleteReplacedFileGroups(HoodieEngineContext context,
HoodieTableMetaClient metaClient,
TableFileSystemView
fileSystemView,
HoodieInstant instant,
List<String> replacedPartitions) {
+ // There is no file id to be replaced in the very first replace commit
file for insert overwrite operation
+ if (replacedPartitions.isEmpty()) {
+ LOG.warn("Found empty partitionToReplaceFileIds");
Review comment:
`partitionToReplaceFileIds` is the field name directly taken from the
replace commit file. I guess it is subject to change. What about just
explaining the warning as `Found no partition files to replace`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
