ssdong commented on a change in pull request #2784:
URL: https://github.com/apache/hudi/pull/2784#discussion_r615512372
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/MetadataConversionUtils.java
##########
@@ -105,14 +117,25 @@ public static HoodieArchivedMetaEntry
createMetaWrapper(HoodieInstant hoodieInst
return archivedMetaWrapper;
}
- public static HoodieArchivedMetaEntry createMetaWrapper(HoodieInstant
hoodieInstant,
- HoodieCommitMetadata
hoodieCommitMetadata) {
- HoodieArchivedMetaEntry archivedMetaWrapper = new
HoodieArchivedMetaEntry();
- archivedMetaWrapper.setCommitTime(hoodieInstant.getTimestamp());
- archivedMetaWrapper.setActionState(hoodieInstant.getState().name());
-
archivedMetaWrapper.setHoodieCommitMetadata(convertCommitMetadata(hoodieCommitMetadata));
- archivedMetaWrapper.setActionType(ActionType.commit.name());
- return archivedMetaWrapper;
+ public static Option<HoodieCommitMetadata>
getInflightReplaceMetadata(HoodieTableMetaClient metaClient, HoodieInstant
instant) throws IOException {
Review comment:
Hmm, I don't think this method is relevant to clustering.. 🤔They are
solely responsible for retrieving corresponding commit files and parse them,
which is more applicable to be residing in a "meta conversion" file, which
comes within `MetadataConversionUtils.java` naturally. In fact, I've gotten rid
of the dependency upon `ClusteringUtils` in `MetadataConversionUtils.java`
after this refactoring. 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
