nsivabalan commented on a change in pull request #2716:
URL: https://github.com/apache/hudi/pull/2716#discussion_r616621197



##########
File path: 
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/hive/HoodieCombineHiveInputFormat.java
##########
@@ -170,7 +170,7 @@ protected HoodieCombineFileInputFormatShim 
createInputFormatShim() {
         if (job.get(hive_metastoreConstants.META_TABLE_PARTITION_COLUMNS, 
"").isEmpty()) {
           List<String> partitions = new 
ArrayList<>(part.getPartSpec().keySet());
           if (!partitions.isEmpty()) {
-            String partitionStr = String.join(",", partitions);

Review comment:
       I am just getting started to understand the query side (and hence not 
very conversant). I tried looking in hive repo for 
[CombineHiveInputFormat](https://github.com/apache/hive/blob/branch-2.3/ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java)
 to find the usage of delimiter, but couldn't find this piece of code. Would 
you mind pointing me to file where I can find this code snippet in hive repo. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to