[GitHub] [hudi] xiarixiaoyao commented on a change in pull request #2716: [HUDI-1718] when query incr view of mor table which has Multi level partitions, the query failed

[GitBox]

xiarixiaoyao commented on a change in pull request #2716:
URL: https://github.com/apache/hudi/pull/2716#discussion_r617137325



##########
File path: 
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/hive/HoodieCombineHiveInputFormat.java
##########
@@ -170,7 +170,7 @@ protected HoodieCombineFileInputFormatShim 
createInputFormatShim() {
         if (job.get(hive_metastoreConstants.META_TABLE_PARTITION_COLUMNS, 
"").isEmpty()) {
           List<String> partitions = new 
ArrayList<>(part.getPartSpec().keySet());
           if (!partitions.isEmpty()) {
-            String partitionStr = String.join(",", partitions);

Review comment:
       @nsivabalan   just see the funtion initObjectInspector in 
MapOperator.java(my hive version is hive 3.1.1):
   
       // Next check if this table has partitions and if so
       // get the list of partition names as well as allocate
       // the serdes for the partition columns
   **line 189**    String pcols = 
overlayedProps.getProperty(hive_metastoreConstants.META_TABLE_PARTITION_COLUMNS);
   
   **line 191**    if (pcols != null && pcols.length() > 0) {
   **line 192**    String[] partKeys = pcols.trim().split("/");




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org