zhedoubushishi commented on a change in pull request #2833:
URL: https://github.com/apache/hudi/pull/2833#discussion_r626256576
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/config/LockConfiguration.java
##########
@@ -28,36 +28,97 @@
public class LockConfiguration implements Serializable {
public static final String LOCK_PREFIX = "hoodie.write.lock.";
- public static final String LOCK_ACQUIRE_RETRY_WAIT_TIME_IN_MILLIS_PROP =
LOCK_PREFIX + "wait_time_ms_between_retry";
- public static final String DEFAULT_LOCK_ACQUIRE_RETRY_WAIT_TIME_IN_MILLIS =
String.valueOf(5000L);
- public static final String LOCK_ACQUIRE_RETRY_MAX_WAIT_TIME_IN_MILLIS_PROP =
LOCK_PREFIX + "max_wait_time_ms_between_retry";
- public static final String
DEFAULT_LOCK_ACQUIRE_MAX_RETRY_WAIT_TIME_IN_MILLIS = String.valueOf(5000L);
- public static final String
LOCK_ACQUIRE_CLIENT_RETRY_WAIT_TIME_IN_MILLIS_PROP = LOCK_PREFIX +
"client.wait_time_ms_between_retry";
- public static final String
DEFAULT_LOCK_ACQUIRE_CLIENT_RETRY_WAIT_TIME_IN_MILLIS = String.valueOf(10000L);
- public static final String LOCK_ACQUIRE_NUM_RETRIES_PROP = LOCK_PREFIX +
"num_retries";
- public static final String DEFAULT_LOCK_ACQUIRE_NUM_RETRIES =
String.valueOf(3);
- public static final String LOCK_ACQUIRE_CLIENT_NUM_RETRIES_PROP =
LOCK_PREFIX + "client.num_retries";
- public static final String DEFAULT_LOCK_ACQUIRE_CLIENT_NUM_RETRIES =
String.valueOf(0);
- public static final String LOCK_ACQUIRE_WAIT_TIMEOUT_MS_PROP = LOCK_PREFIX +
"wait_time_ms";
- public static final int DEFAULT_ACQUIRE_LOCK_WAIT_TIMEOUT_MS = 60 * 1000;
+
+ public static final ConfigOption<String>
LOCK_ACQUIRE_RETRY_WAIT_TIME_IN_MILLIS_PROP = ConfigOption
+ .key(LOCK_PREFIX + "wait_time_ms_between_retry")
+ .defaultValue(String.valueOf(5000L))
+ .withDescription("");
+
+ public static final ConfigOption<String>
LOCK_ACQUIRE_RETRY_MAX_WAIT_TIME_IN_MILLIS_PROP = ConfigOption
+ .key(LOCK_PREFIX + "max_wait_time_ms_between_retry")
+ .defaultValue(String.valueOf(5000L))
+ .withDescription("Initial amount of time to wait between retries by lock
provider client");
Review comment:
Good catch! No it should be the max time to wait used by the exponential
backoff retry policy. Changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
