zhedoubushishi commented on a change in pull request #2833:
URL: https://github.com/apache/hudi/pull/2833#discussion_r638344210
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/callback/kafka/HoodieWriteCommitKafkaCallbackConfig.java
##########
@@ -17,32 +17,49 @@
package org.apache.hudi.utilities.callback.kafka;
+import org.apache.hudi.common.config.ConfigOption;
+
import java.util.Properties;
-import static
org.apache.hudi.common.config.DefaultHoodieConfig.setDefaultOnCondition;
+import static org.apache.hudi.common.config.HoodieConfig.setDefaultValue;
import static
org.apache.hudi.config.HoodieWriteCommitCallbackConfig.CALLBACK_PREFIX;
/**
* Kafka write callback related config.
*/
public class HoodieWriteCommitKafkaCallbackConfig {
Review comment:
Let it extend ```HoodieConfig```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
