zhedoubushishi commented on a change in pull request #2833:
URL: https://github.com/apache/hudi/pull/2833#discussion_r647728123
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/LockManager.java
##########
@@ -61,8 +61,8 @@ public void lock() {
LockProvider lockProvider = getLockProvider();
int retryCount = 0;
boolean acquired = false;
- int retries =
lockConfiguration.getConfig().getInteger(LOCK_ACQUIRE_CLIENT_NUM_RETRIES_PROP);
- long waitTimeInMs =
lockConfiguration.getConfig().getInteger(LOCK_ACQUIRE_CLIENT_RETRY_WAIT_TIME_IN_MILLIS_PROP);
+ int retries =
lockConfiguration.getConfig().getInteger(LOCK_ACQUIRE_CLIENT_NUM_RETRIES_PROP_KEY);
Review comment:
Some default values of ```LockConfiguration``` is not in
```hudi-common```. For example, the default value of
```WRITE_CONFLICT_RESOLUTION_STRATEGY_CLASS_PROP``` is in the
```hudi-client-common``` package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
