leesf commented on a change in pull request #3092:
URL: https://github.com/apache/hudi/pull/3092#discussion_r655482935
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/KafkaOffsetGen.java
##########
@@ -157,29 +161,23 @@ public static long totalNewMessages(OffsetRange[] ranges)
{
private static final String KAFKA_TOPIC_NAME =
"hoodie.deltastreamer.source.kafka.topic";
private static final String MAX_EVENTS_FROM_KAFKA_SOURCE_PROP =
"hoodie.deltastreamer.kafka.source.maxEvents";
+ public static final String ENABLE_KAFKA_COMMIT_OFFSET =
"hoodie.deltastreamer.source.enable.kafka.commit.offset";
Review comment:
can we rename to
`hoodie.deltastreamer.source.kafka.enable.commit.offset` to align with
`hoodie.deltastreamer.source.kafka.topic` and would possibly rename
`hoodie.deltastreamer.kafka.source.maxEvents` to
`hoodie.deltastreamer.source.kafka.maxEvents`(should consider the compatibility)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
