veenaypatil commented on a change in pull request #3092:
URL: https://github.com/apache/hudi/pull/3092#discussion_r655512304
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/KafkaOffsetGen.java
##########
@@ -297,7 +295,37 @@ public String getTopicName() {
return topicName;
}
- public HashMap<String, Object> getKafkaParams() {
+ public Map<String, Object> getKafkaParams() {
+ return kafkaParams;
+ }
+
+ private static Map<String, Object> excludeHoodieConfigs(TypedProperties
props) {
Review comment:
Are you proposing to create `KafkaOffsetGen` object in `DeltaSync` as
well to call `commitOffsetToKafka` method ? I wanted to avoid doing it as we
are already doing so in respective Source classes. Also, I saw
`excludeHoodieConfigs ` as helper method, hence created static
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
