[
https://issues.apache.org/jira/browse/HUDI-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372453#comment-17372453
]
ASF GitHub Bot commented on HUDI-2093:
--------------------------------------
wangxianghu commented on a change in pull request #3177:
URL: https://github.com/apache/hudi/pull/3177#discussion_r662036803
##########
File path:
hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java
##########
@@ -106,17 +106,17 @@ private FlinkOptions() {
.defaultValue(4)
.withDescription("Parallelism of tasks that do actual read, default is
4");
- public static final ConfigOption<String> READ_AVRO_SCHEMA_PATH =
ConfigOptions
- .key("read.avro-schema.path")
+ public static final ConfigOption<String> SOURCE_AVRO_SCHEMA_PATH =
ConfigOptions
+ .key("source.avro-schema.path")
.stringType()
- .noDefaultValue()
- .withDescription("Avro schema file path, the parsed schema is used for
deserialization");
+ .defaultValue("")
+ .withDescription("Source avro schema file path, the parsed schema is
used for deserialization");
- public static final ConfigOption<String> READ_AVRO_SCHEMA = ConfigOptions
- .key("read.avro-schema")
+ public static final ConfigOption<String> SOURCE_AVRO_SCHEMA = ConfigOptions
+ .key("source.avro-schema")
.stringType()
- .noDefaultValue()
- .withDescription("Avro schema string, the parsed schema is used for
deserialization");
+ .defaultValue("")
+ .withDescription("Source avro schema file path, the parsed schema is
used for deserialization");
Review comment:
will file a ticket to update the doc on website if we agree with this
change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix empty avro schema path caused by duplicate parameters
> ---------------------------------------------------------
>
> Key: HUDI-2093
> URL: https://issues.apache.org/jira/browse/HUDI-2093
> Project: Apache Hudi
> Issue Type: Bug
> Reporter: Xianghu Wang
> Assignee: Xianghu Wang
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
