[
https://issues.apache.org/jira/browse/HUDI-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372664#comment-17372664
]
ASF GitHub Bot commented on HUDI-2093:
--------------------------------------
wangxianghu commented on a change in pull request #3177:
URL: https://github.com/apache/hudi/pull/3177#discussion_r662192256
##########
File path:
hudi-flink/src/main/java/org/apache/hudi/streamer/FlinkStreamerConfig.java
##########
@@ -150,11 +145,12 @@
description = "Whether to load partitions in state if partition path
matching， default *")
public String indexPartitionRegex = ".*";
- @Parameter(names = {"--avro-schema-path"}, description = "Avro schema file
path, the parsed schema is used for deserialization")
- public String avroSchemaPath = "";
+ @Parameter(names = {"--avro-schema-path"}, description = "Avro schema file
path, the parsed schema is used for deserialization",
+ required = true)
+ public String avroSchemaPath;
Review comment:
> `avro-schema-path` should not be required ? Because specify the
`avroSchema` also works. They both should have a default value "".
@danny0405 I see the `READ_AVRO_SCHEMA_PATH` and `READ_AVRO_SCHEMA` in
`FlinkOptions` have no default value. can we keep them the same?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix empty avro schema path caused by duplicate parameters
> ---------------------------------------------------------
>
> Key: HUDI-2093
> URL: https://issues.apache.org/jira/browse/HUDI-2093
> Project: Apache Hudi
> Issue Type: Bug
> Reporter: Xianghu Wang
> Assignee: Xianghu Wang
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
