vinothchandar commented on pull request #2296: URL: https://github.com/apache/hudi/pull/2296#issuecomment-876078470
I suggest the following approach here - Allow empty commit and make the code work even if there is an empty commit. I think it should be fine. - Introduce a flag that avoids the commit, if commit stats is empty and turn it on for the spark datasource writer path, as an optimization. On this, @garyli1019 > This seems like a bug introduced here... https://github.com/apache/hudi/pull/1121/files > We should definitely return if the incoming record is empty. cc: @vinothchandar WDYT? Agree. I think it does return actually (scala does not need these return), if you notice the block finally returns like this . Good to confirm though https://github.com/apache/hudi/blob/16e90d30eaa14e5c1c4632ad0a90497df601c637/hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala#L196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
