danny0405 commented on a change in pull request #3267:
URL: https://github.com/apache/hudi/pull/3267#discussion_r670948572
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/model/OverwriteWithLatestAvroPayload.java
##########
@@ -49,7 +49,7 @@ public OverwriteWithLatestAvroPayload(Option<GenericRecord>
record) {
@Override
public OverwriteWithLatestAvroPayload
preCombine(OverwriteWithLatestAvroPayload another) {
// pick the payload with greatest ordering value
- if (another.orderingVal.compareTo(orderingVal) > 0) {
+ if (another.orderingVal.compareTo(orderingVal) >= 0) {
Review comment:
Finally i found that the `another` should always be the old value. So
the original logic is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
