danny0405 commented on a change in pull request #3267:
URL: https://github.com/apache/hudi/pull/3267#discussion_r670949047
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/model/OverwriteWithLatestAvroPayload.java
##########
@@ -90,6 +93,14 @@ protected boolean isDeleteRecord(GenericRecord
genericRecord) {
return (deleteMarker instanceof Boolean && (boolean) deleteMarker);
}
+ /**
+ * Returns the ordering value of given record {@code record}.
+ */
+ protected static Object getOrderingVal(GenericRecord record, Properties
properties) {
+ return getNestedFieldVal(record,
+
properties.getProperty(HoodiePayloadProps.PAYLOAD_ORDERING_FIELD_PROP_KEY),
true);
Review comment:
Actually there is no need to care about whether the record comes from
the persisted file or not, just fetch it and return null if the old schema does
not contains the `preCombine` field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
