leesf commented on a change in pull request #3330:
URL: https://github.com/apache/hudi/pull/3330#discussion_r675936338
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/cluster/SparkExecuteClusteringCommitActionExecutor.java
##########
@@ -105,6 +106,19 @@ public
SparkExecuteClusteringCommitActionExecutor(HoodieEngineContext context,
validateWriteResult(writeMetadata);
commitOnAutoCommit(writeMetadata);
if (!writeMetadata.getCommitMetadata().isPresent()) {
+ WriteOperationType realOperationType = operationType;
+ Option<Map<String, String>> realExtraMetadata = extraMetadata;
+ if
(config.getClusteringExecutionStrategyClass().equals("org.apache.hudi.clustering.SparkZSortAndSizeExecutionStrategy"))
{
+ realOperationType = WriteOperationType.ZORDER;
+ Map<String, String> metaDataMap = new HashMap<>();
+ if (extraMetadata.isPresent()) {
+ metaDataMap = extraMetadata.get();
+ }
+ metaDataMap.put("_hoodie.zorder.cols", clusteringPlan.getStrategy()
+
.getStrategyParams().getOrDefault("hoodie.clustering.plan.strategy.sort.columns",
""));
Review comment:
here why use clustering sort columns instead of defining
hoodie.zorder.columns? is hoodie.zorder.cols an internal concept?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
