xiarixiaoyao commented on a change in pull request #3330:
URL: https://github.com/apache/hudi/pull/3330#discussion_r676237940
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##########
@@ -182,6 +183,13 @@ public boolean commitStats(String instantTime,
List<HoodieWriteStat> stats, Opti
try {
preCommit(instantTime, metadata);
commit(table, commitActionType, instantTime, metadata, stats);
+ if (extraMetadata.isPresent() &&
extraMetadata.get().containsKey("_hoodie.zorder.enable")) {
Review comment:
this prameter is internal used. i will try to optimize it
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##########
@@ -182,6 +183,13 @@ public boolean commitStats(String instantTime,
List<HoodieWriteStat> stats, Opti
try {
preCommit(instantTime, metadata);
commit(table, commitActionType, instantTime, metadata, stats);
+ if (extraMetadata.isPresent() &&
extraMetadata.get().containsKey("_hoodie.zorder.enable")) {
+ String basePath = table.getMetaClient().getBasePath();
+ String indexPath = table.getMetaClient().getZindexPath();
+ List<String> zFiles = stats.stream().map(s -> new Path(basePath,
s.getPartitionPath()).toString()).collect(Collectors.toList());
+ saveStatisticsInfo(zFiles,
+ extraMetadata.get().getOrDefault("_hoodie.zorder.cols", ""),
indexPath, "append");
Review comment:
ok, will do it
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java
##########
@@ -238,6 +238,17 @@ private synchronized FileSystemViewManager
getViewManager() {
*/
public abstract HoodieWriteMetadata<O>
insertOverwriteTable(HoodieEngineContext context, String instantTime, I
records);
+ /**
+ * Replaces all the existing records of the Hoodie table and inserts z-sort
records into Hoodie table at the supplied instantTime,
+ * for the partition paths contained in input records.
+ *
+ * @param context HoodieEngineContext
+ * @param instantTime Instant time for the replace action
+ * @param records input records
+ * @return HoodieWriteMetadata
+ */
+ public abstract HoodieWriteMetadata<O> zorderWrite(HoodieEngineContext
context, String instantTime, I records);
Review comment:
yes, will do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
