nsivabalan commented on a change in pull request #3318:
URL: https://github.com/apache/hudi/pull/3318#discussion_r676902279
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/view/SpillableMapBasedFileSystemView.java
##########
@@ -63,6 +67,9 @@ public SpillableMapBasedFileSystemView(HoodieTableMetaClient
metaClient, HoodieT
this.maxMemoryForReplaceFileGroups =
config.getMaxMemoryForReplacedFileGroups();
this.maxMemoryForClusteringFileGroups =
config.getMaxMemoryForPendingClusteringFileGroups();
this.baseStoreDir = config.getSpillableDir();
+ HoodieCommonConfig commonConfig =
HoodieCommonConfig.newBuilder().fromProperties(config.getProps()).build();
Review comment:
Do you think we should pass this config from the caller itself.
Basically whereever we create/instantiate FileSystemViewStorageConfig, should
also create/instantiate HoodieCommonConfig and pass it along.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
