[
https://issues.apache.org/jira/browse/HUDI-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17387608#comment-17387608
]
ASF GitHub Bot commented on HUDI-2044:
--------------------------------------
nsivabalan commented on a change in pull request #3318:
URL: https://github.com/apache/hudi/pull/3318#discussion_r676902279
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/view/SpillableMapBasedFileSystemView.java
##########
@@ -63,6 +67,9 @@ public SpillableMapBasedFileSystemView(HoodieTableMetaClient
metaClient, HoodieT
this.maxMemoryForReplaceFileGroups =
config.getMaxMemoryForReplacedFileGroups();
this.maxMemoryForClusteringFileGroups =
config.getMaxMemoryForPendingClusteringFileGroups();
this.baseStoreDir = config.getSpillableDir();
+ HoodieCommonConfig commonConfig =
HoodieCommonConfig.newBuilder().fromProperties(config.getProps()).build();
Review comment:
Do you think we should pass this config from the caller itself.
Basically whereever we create/instantiate FileSystemViewStorageConfig, should
also create/instantiate HoodieCommonConfig and pass it along.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Extend support for rockDB and compression for Spillable map to all consumers
> of ExternalSpillableMap
> ----------------------------------------------------------------------------------------------------
>
> Key: HUDI-2044
> URL: https://issues.apache.org/jira/browse/HUDI-2044
> Project: Apache Hudi
> Issue Type: Improvement
> Reporter: Rajesh Mahindra
> Assignee: Rajesh Mahindra
> Priority: Major
> Labels: pull-request-available
>
> # HUDI-2028 only implements rockDb support for Spillable map in
> HoodieMergeHandle since we are blocked on the configuration refactor PR to
> land
> # This ticket will track the implementation to extend rocksDB (and
> compression for bit cask) support for Spoilable Map to all consumers of
> ExternalSpillableMap.java
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
