[
https://issues.apache.org/jira/browse/HUDI-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17385153#comment-17385153
] ASF GitHub Bot commented on HUDI-2044: -------------------------------------- codecov-commenter edited a comment on pull request #3318: URL: https://github.com/apache/hudi/pull/3318#issuecomment-884133172 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3318?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#3318](https://codecov.io/gh/apache/hudi/pull/3318?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9c810f1) into [master](https://codecov.io/gh/apache/hudi/commit/d58a8348dc729c83c60025fc8dbed3ecec28578b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d58a834) will **decrease** coverage by `0.01%`. > The diff coverage is `65.62%`. [](https://codecov.io/gh/apache/hudi/pull/3318?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #3318 +/- ## ============================================ - Coverage 45.66% 45.65% -0.02% + Complexity 5600 5597 -3 ============================================ Files 999 1000 +1 Lines 43781 43825 +44 Branches 4403 4403 ============================================ + Hits 19993 20007 +14 - Misses 22004 22034 +30 Partials 1784 1784 ``` | Flag | Coverage Δ | | |---|---|---| | hudicli | `40.02% <100.00%> (+0.05%)` | :arrow_up: | | hudiclient | `34.54% <50.00%> (-0.01%)` | :arrow_down: | | hudicommon | `48.66% <66.66%> (+0.01%)` | :arrow_up: | | hudiflink | `59.67% <100.00%> (+0.01%)` | :arrow_up: | | hudihadoopmr | `52.10% <100.00%> (+0.08%)` | :arrow_up: | | hudiintegtest | `0.00% <0.00%> (ø)` | | | hudisparkdatasource | `67.10% <ø> (-0.31%)` | :arrow_down: | | hudisync | `55.97% <ø> (ø)` | | | huditimelineservice | `64.07% <ø> (ø)` | | | hudiutilities | `59.87% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3318?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...ain/java/org/apache/hudi/io/HoodieMergeHandle.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | | | [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...pache/hudi/metadata/HoodieBackedTableMetadata.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllQmFja2VkVGFibGVNZXRhZGF0YS5qYXZh) | `0.00% <0.00%> (ø)` | | | [...metadata/HoodieMetadataMergedLogRecordScanner.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllTWV0YWRhdGFNZXJnZWRMb2dSZWNvcmRTY2FubmVyLmphdmE=) | `0.00% <0.00%> (ø)` | | | [.../testsuite/reader/DFSHoodieDatasetInputReader.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1pbnRlZy10ZXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2ludGVnL3Rlc3RzdWl0ZS9yZWFkZXIvREZTSG9vZGllRGF0YXNldElucHV0UmVhZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `43.07% <50.00%> (-0.30%)` | :arrow_down: | | [.../apache/hudi/common/config/HoodieCommonConfig.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2NvbmZpZy9Ib29kaWVDb21tb25Db25maWcuamF2YQ==) | `70.83% <70.83%> (ø)` | | | [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | `83.72% <100.00%> (+0.25%)` | :arrow_up: | | [...er/SparkExecuteClusteringCommitActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NsdXN0ZXIvU3BhcmtFeGVjdXRlQ2x1c3RlcmluZ0NvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `89.62% <100.00%> (+0.19%)` | :arrow_up: | | [.../compact/HoodieSparkMergeOnReadTableCompactor.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllU3BhcmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | `94.59% <100.00%> (+0.09%)` | :arrow_up: | | ... and [8 more](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/3318?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/3318?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d58a834...9c810f1](https://codecov.io/gh/apache/hudi/pull/3318?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] > Extend support for rockDB and compression for Spillable map to all consumers > of ExternalSpillableMap > ---------------------------------------------------------------------------------------------------- > > Key: HUDI-2044 > URL: https://issues.apache.org/jira/browse/HUDI-2044 > Project: Apache Hudi > Issue Type: Improvement > Reporter: Rajesh Mahindra > Assignee: Rajesh Mahindra > Priority: Major > Labels: pull-request-available > > # HUDI-2028 only implements rockDb support for Spillable map in > HoodieMergeHandle since we are blocked on the configuration refactor PR to > land > # This ticket will track the implementation to extend rocksDB (and > compression for bit cask) support for Spoilable Map to all consumers of > ExternalSpillableMap.java -- This message was sent by Atlassian Jira (v8.3.4#803005)
