nsivabalan commented on a change in pull request #3315:
URL: https://github.com/apache/hudi/pull/3315#discussion_r677883351
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/keygen/KeyGenUtils.java
##########
@@ -60,7 +60,7 @@ public static String
getRecordKeyFromGenericRecord(GenericRecord genericRecord,
* @return the partition path for the passed in generic record.
*/
public static String getPartitionPathFromGenericRecord(GenericRecord
genericRecord, Option<BaseKeyGenerator> keyGeneratorOpt) {
- return keyGeneratorOpt.isPresent() ?
keyGeneratorOpt.get().getRecordKey(genericRecord) :
genericRecord.get(HoodieRecord.PARTITION_PATH_METADATA_FIELD).toString();
+ return keyGeneratorOpt.isPresent() ?
keyGeneratorOpt.get().getPartitionPath(genericRecord) :
genericRecord.get(HoodieRecord.PARTITION_PATH_METADATA_FIELD).toString();
Review comment:
this was never invoked for COW table and hence didn't hit this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
